4519 graphql change so we use delete multiple command when deleting files from s3 (#159)

* now use deleteObjects plural instead of single delete

* fixed when nothing is removed
This commit is contained in:
Arwid Thornström
2023-10-25 14:14:41 +02:00
committed by GitHub
parent b2a296c857
commit 2a9b7a88ee
2 changed files with 12 additions and 10 deletions
+6 -7
View File
@@ -1044,15 +1044,14 @@ export class ProductAPI extends BaseSQLDataSource {
}
// Setup all delete actions
const deletePromises = shouldRemove.map((file) => {
return deleteFiles(CONFIG.imageBucket, file);
});
// Run all delete in parallell
await Promise.all(deletePromises);
let removed = [];
if (shouldRemove.length > 0) {
const response = await deleteFiles(CONFIG.imageBucket, shouldRemove);
removed = response.Deleted?.map((item) => item.Key) || [];
}
// Return what we did
return { active: shouldKeep, deleted: shouldRemove };
return { active: shouldKeep, deleted: removed };
}
/**