fix(deltagare, employee, avrop): Resetting params after destroy to avoid state issues. (TV-756)

Squashed commit of the following:

commit 4cd30d9dafd2cbd17e5192142e5ba8116345fd18
Author: Erik Tiekstra <erik.tiekstra@arbetsformedlingen.se>
Date:   Tue Oct 12 19:55:32 2021 +0200

    Added reset on destroy for all params when fetching lists
This commit is contained in:
Erik Tiekstra
2021-10-13 11:05:55 +02:00
parent ccf3eb5458
commit bdb1d16115
5 changed files with 53 additions and 28 deletions

View File

@@ -1,4 +1,4 @@
import { ChangeDetectionStrategy, Component } from '@angular/core';
import { ChangeDetectionStrategy, Component, OnDestroy } from '@angular/core';
import { IconType } from '@msfa-enums/icon-type.enum';
import { EmployeeCompactResponse } from '@msfa-models/api/employee.response.model';
import { Employee, EmployeesData } from '@msfa-models/employee.model';
@@ -12,7 +12,7 @@ import { BehaviorSubject, Observable } from 'rxjs';
styleUrls: ['./employees.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class EmployeesComponent {
export class EmployeesComponent implements OnDestroy {
private _searchValue$ = new BehaviorSubject<string>('');
onlyEmployeesWithoutAuthorization$: Observable<boolean> = this.employeeService.onlyEmployeesWithoutAuthorization$;
employeesData$: Observable<EmployeesData> = this.employeeService.employeesData$;
@@ -22,6 +22,10 @@ export class EmployeesComponent {
constructor(private employeeService: EmployeeService) {}
ngOnDestroy(): void {
this.employeeService.resetParams();
}
get searchValue(): string {
return this._searchValue$.getValue();
}

View File

@@ -1,4 +1,4 @@
import { ChangeDetectionStrategy, Component } from '@angular/core';
import { ChangeDetectionStrategy, Component, OnDestroy } from '@angular/core';
import { DeltagareCompact, DeltagareCompactData } from '@msfa-models/deltagare.model';
import { Sort } from '@msfa-models/sort.model';
import { DeltagareService } from '@msfa-services/deltagare.service';
@@ -10,7 +10,7 @@ import { Observable } from 'rxjs';
styleUrls: ['./deltagare-list.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DeltagareListComponent {
export class DeltagareListComponent implements OnDestroy {
allDeltagareData$: Observable<DeltagareCompactData> = this.deltagareService.allDeltagareData$;
sort$: Observable<Sort<keyof DeltagareCompact>> = this.deltagareService.sort$;
onlyMyDeltagare$: Observable<boolean> = this.deltagareService.onlyMyDeltagare$;
@@ -19,6 +19,10 @@ export class DeltagareListComponent {
constructor(private deltagareService: DeltagareService) {}
ngOnDestroy(): void {
this.deltagareService.resetParams();
}
handleDeltagareSort(key: keyof DeltagareCompact): void {
this.deltagareService.setSort(key);
}