From 9bb6bc55d5ba6b736bf45ccc02ea7995df2171a2 Mon Sep 17 00:00:00 2001 From: Daniel Appelgren Date: Thu, 18 Nov 2021 15:15:01 +0100 Subject: [PATCH] change ifs to switch-case --- .../signal-view/signal-view.component.ts | 30 ++++++++++--------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/apps/mina-sidor-fa/src/app/pages/deltagare/pages/deltagare-details/pages/report-views/signal-view/signal-view.component.ts b/apps/mina-sidor-fa/src/app/pages/deltagare/pages/deltagare-details/pages/report-views/signal-view/signal-view.component.ts index 62d36bb..ccbc775 100644 --- a/apps/mina-sidor-fa/src/app/pages/deltagare/pages/deltagare-details/pages/report-views/signal-view/signal-view.component.ts +++ b/apps/mina-sidor-fa/src/app/pages/deltagare/pages/deltagare-details/pages/report-views/signal-view/signal-view.component.ts @@ -28,23 +28,25 @@ export class SignalViewComponent { switchMap(({ handlingId }) => this.signalViewService.fetchSignal$(handlingId as string)), shareReplay(1) ); - typeToText(type: string) { - if (type === 'arbete') { - return 'Arbete'; + typeToText(type: string): string { + switch (type) { + case 'arbete': + return 'Arbete'; + case 'utbildning': + return 'Utbildning'; + default: + return 'Okänd'; } - if (type === 'utbildning') { - return 'Utbildning'; - } - return 'Okänd'; } - omfattningToText(omfattning: string) { - if (omfattning === 'heltid') { - return 'Heltid'; + omfattningToText(omfattning: string): string { + switch (omfattning) { + case 'heltid': + return 'Heltid'; + case 'deltid': + return 'Deltid'; + default: + return 'Okänd'; } - if (omfattning === 'deltid') { - return 'Deltid'; - } - return 'Okänd'; } constructor(private signalViewService: SignalViewService, private activatedRoute: ActivatedRoute) {}