From 803422dbc56847f4a9b8b02ca2dec7288b21ce0f Mon Sep 17 00:00:00 2001
From: Erik Tiekstra <erik.tiekstra@arbetsformedlingen.se>
Date: Wed, 1 Sep 2021 13:39:01 +0200
Subject: [PATCH] Fixed some issues with invites mock-data and response from
 api

---
 .../employee-invite.component.html            | 13 +++--
 .../employee-invite.component.ts              | 58 +++++++++++--------
 .../api/employee-invite.response.model.ts     | 20 ++++++-
 .../src/app/shared/models/employee.model.ts   | 16 +++--
 .../shared/services/api/employee.service.ts   | 13 +++--
 mock-api/mina-sidor-fa/server.js              | 19 ++++--
 6 files changed, 91 insertions(+), 48 deletions(-)

diff --git a/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.html b/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.html
index 82d6d11..4e70941 100644
--- a/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.html
+++ b/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.html
@@ -2,7 +2,7 @@
   <section class="employee-invite">
     <digi-typography>
       <h1>Skapa nytt personalkonto</h1>
-      <p>Såhär skapar du ett nytt personalkonto:</p>
+      <p>Så här skapar du ett nytt personalkonto:</p>
       <ol>
         <li>Skicka en inbjudningslänk till personalens e-postadress.</li>
         <li>Personalen öppnar inbjudningslänken via sin e-post och skapar ett personalkonto med sitt Bank-ID.</li>
@@ -32,9 +32,9 @@
             afLabel="E-postadress"
             afType="email"
             [afRequired]="true"
-            [afInvalidMessage]="email.errors?.message || 'Ogiltig e-postadress'"
+            [afInvalidMessage]="emailControl.errors?.message || 'Ogiltig e-postadress'"
             [afDisableValidStyle]="true"
-            [afInvalid]="email.invalid && email.dirty"
+            [afInvalid]="emailControl.invalid && emailControl.dirty"
           ></digi-ng-form-input>
           <digi-button af-size="m" af-type="submit" class="employee-invite__invitation-btn"
             >Skicka inbjudningslänk</digi-button
@@ -42,14 +42,17 @@
         </div>
       </div>
       <digi-notification-alert
-        *ngIf="(latestSubmittedInvite$ | async) as latestSubmittedInvite"
+        *ngIf="(lastInvite$ | async) as lastInvite"
         af-variation="success"
         af-heading="Allt gick bra"
         af-heading-level="h3"
         af-closeable="true"
         (click)="onCloseAlert()"
       >
-        <p>Inbjudan har skickats till {{latestSubmittedInvite.email}}</p>
+        <p *ngIf="lastInvitedNewUsers?.length">Inbjudan har skickats till {{lastInvitedNewUsers.join(', ')}}.</p>
+        <p *ngIf="lastInvitedExistingUsers?.length">
+          Följande personal är redan registrerat: {{lastInvitedExistingUsers.join(', ')}}.
+        </p>
       </digi-notification-alert>
 
       <footer class="employee-invite__footer">
diff --git a/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.ts b/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.ts
index c4d413f..ea961ae 100644
--- a/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.ts
+++ b/apps/mina-sidor-fa/src/app/pages/administration/pages/employee-invite/employee-invite.component.ts
@@ -1,5 +1,6 @@
-import { ChangeDetectionStrategy, Component, OnInit } from '@angular/core';
-import { FormControl, FormGroup, Validators } from '@angular/forms';
+import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { AbstractControl, FormControl, FormGroup, Validators } from '@angular/forms';
+import { EmployeeInviteResponse } from '@msfa-models/api/employee-invite.response.model';
 import { EmployeeService } from '@msfa-services/api/employee.service';
 import { RequiredValidator } from '@msfa-utils/validators/required.validator';
 import { BehaviorSubject, Observable } from 'rxjs';
@@ -10,46 +11,57 @@ import { BehaviorSubject, Observable } from 'rxjs';
   styleUrls: ['./employee-invite.component.scss'],
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class EmployeeInviteComponent implements OnInit {
-  form: FormGroup;
-  private latestSubmittedInvite_ = new BehaviorSubject<string>('');
-  latestSubmittedInvite$: Observable<string> = this.latestSubmittedInvite_.asObservable();
+export class EmployeeInviteComponent {
+  form: FormGroup = new FormGroup({
+    email: new FormControl('', [
+      RequiredValidator('E-postadress'),
+      Validators.pattern('^[a-z0-9._%+-]+@[a-z0-9.-]+\\.[a-z]{2,4}$'),
+    ]),
+  });
+  private _lastInvite$ = new BehaviorSubject<EmployeeInviteResponse>(null);
+  lastInvite$: Observable<EmployeeInviteResponse> = this._lastInvite$.asObservable();
 
   constructor(private employeeService: EmployeeService) {}
 
-  ngOnInit(): void {
-    this.form = new FormGroup({
-      email: new FormControl('', [
-        RequiredValidator('E-postadress'),
-        Validators.pattern('^[a-z0-9._%+-]+@[a-z0-9.-]+\\.[a-z]{2,4}$'),
-      ]),
-    });
-  }
-
-  get email() {
+  get emailControl(): AbstractControl {
     return this.form.get('email');
   }
 
+  get lastInvite(): EmployeeInviteResponse {
+    return this._lastInvite$.getValue();
+  }
+
+  get lastInvitedNewUsers(): string[] {
+    const invitedUsers = this.lastInvite?.invitedUsers || [];
+    const assignedUsers = this.lastInvite?.assignedUsers || [];
+    return [...invitedUsers, ...assignedUsers.map(assigned => assigned.email)];
+  }
+
+  get lastInvitedExistingUsers(): string[] {
+    const existingUsersInCurrentOrg = this.lastInvite?.existingUsersInCurrentOrg || [];
+    return existingUsersInCurrentOrg.map(existing => existing.email);
+  }
+
   submitForm(): void {
+    this._lastInvite$.next(null);
     if (this.form.invalid) {
-      this.email.markAsDirty();
-      this.email.markAsTouched();
+      this.emailControl.markAsDirty();
+      this.emailControl.markAsTouched();
       return;
     }
 
-    const post = this.employeeService.postEmployeeInvitation(this.form.value).subscribe({
-      next: () => {
-        this.latestSubmittedInvite_.next(this.form.value);
+    const post = this.employeeService.postEmployeeInvitation(this.emailControl.value).subscribe({
+      next: data => {
+        this._lastInvite$.next(data);
         this.form.reset();
       },
       complete: () => {
         post.unsubscribe();
       },
-      error: (err) => console.log(err)
     });
   }
 
   onCloseAlert(): void {
-    this.latestSubmittedInvite_.next('');
+    this._lastInvite$.next(null);
   }
 }
diff --git a/apps/mina-sidor-fa/src/app/shared/models/api/employee-invite.response.model.ts b/apps/mina-sidor-fa/src/app/shared/models/api/employee-invite.response.model.ts
index 9ddfb47..a24bb4a 100644
--- a/apps/mina-sidor-fa/src/app/shared/models/api/employee-invite.response.model.ts
+++ b/apps/mina-sidor-fa/src/app/shared/models/api/employee-invite.response.model.ts
@@ -1,4 +1,18 @@
-export interface EmployeeInviteMockApiResponse {
-  id: number,
-  createdAt: number
+interface ExistingUser {
+  ciamUserId: string;
+  firstName: string;
+  lastName: string;
+  email: string;
+  status: string;
+  roles: string[];
+  tjansteKoder: string[];
+  allaUtforandeVerksamheter: boolean;
+  utforandeVerksamhetIds: number[];
+  adressIds: number[];
+}
+
+export interface EmployeeInviteResponse {
+  assignedUsers: ExistingUser[];
+  invitedUsers: string[];
+  existingUsersInCurrentOrg: ExistingUser[];
 }
diff --git a/apps/mina-sidor-fa/src/app/shared/models/employee.model.ts b/apps/mina-sidor-fa/src/app/shared/models/employee.model.ts
index 6039c3a..cbef6cb 100644
--- a/apps/mina-sidor-fa/src/app/shared/models/employee.model.ts
+++ b/apps/mina-sidor-fa/src/app/shared/models/employee.model.ts
@@ -42,12 +42,16 @@ export interface EmployeeRequestData {
   adressIds: number[];
 }
 
-export interface EmployeeInviteRequestData {
-  emails: string[];
-}
-
 export function mapEmployeeToRequestData(data: Employee): EmployeeRequestData {
-  const { email, roles, tjanstCodes, allaUtforandeVerksamheter, utforandeVerksamhet, utforandeVerksamhetIds, utforandeAdressIds } = data;
+  const {
+    email,
+    roles,
+    tjanstCodes,
+    allaUtforandeVerksamheter,
+    utforandeVerksamhet,
+    utforandeVerksamhetIds,
+    utforandeAdressIds,
+  } = data;
 
   return {
     email,
@@ -56,7 +60,7 @@ export function mapEmployeeToRequestData(data: Employee): EmployeeRequestData {
     utforandeVerksamhetIds,
     adressIds: utforandeAdressIds,
     allaUtforandeVerksamheter: allaUtforandeVerksamheter,
-    utforandeVerksamhet: utforandeVerksamhet
+    utforandeVerksamhet: utforandeVerksamhet,
   };
 }
 
diff --git a/apps/mina-sidor-fa/src/app/shared/services/api/employee.service.ts b/apps/mina-sidor-fa/src/app/shared/services/api/employee.service.ts
index 2a1766d..7c69150 100644
--- a/apps/mina-sidor-fa/src/app/shared/services/api/employee.service.ts
+++ b/apps/mina-sidor-fa/src/app/shared/services/api/employee.service.ts
@@ -6,6 +6,7 @@ import { RoleEnum } from '@msfa-enums/role.enum';
 import { SortOrder } from '@msfa-enums/sort-order.enum';
 import { environment } from '@msfa-environment';
 import { DeleteEmployeeMockApiResponse } from '@msfa-models/api/delete-employee.response.model';
+import { EmployeeInviteResponse } from '@msfa-models/api/employee-invite.response.model';
 import {
   EmployeeCompactResponse,
   EmployeeResponse,
@@ -14,7 +15,6 @@ import {
 import { Params } from '@msfa-models/api/params.model';
 import {
   Employee,
-  EmployeeInviteRequestData,
   EmployeesData,
   mapEmployeeToRequestData,
   mapResponseToEmployee,
@@ -25,7 +25,7 @@ import { mapRoleResponseToRoleObject, Role } from '@msfa-models/role.model';
 import { Sort } from '@msfa-models/sort.model';
 import { ErrorService } from '@msfa-services/error.service';
 import { BehaviorSubject, combineLatest, Observable, of, throwError } from 'rxjs';
-import { catchError, filter, map, switchMap, take } from 'rxjs/operators';
+import { catchError, filter, map, switchMap, take, tap } from 'rxjs/operators';
 import { TjanstService } from './tjanst.service';
 
 @Injectable({
@@ -177,14 +177,15 @@ export class EmployeeService extends UnsubscribeDirective {
     );
   }
 
-  public postEmployeeInvitation(email: string): Observable<string[]> {
+  public postEmployeeInvitation(email: string): Observable<EmployeeInviteResponse> {
     return this.httpClient
-      .patch<{ data: EmployeeInviteRequestData }>(`${this._apiBaseUrl}/invite`, {
-        emails: Object.values(email),
+      .patch<{ data: EmployeeInviteResponse }>(`${this._apiBaseUrl}/invite`, {
+        emails: [email],
       })
       .pipe(
         take(1),
-        map(res => res.data.emails),
+        tap(res => console.log(res)),
+        map(res => res.data),
         catchError(error => throwError({ message: error as string, type: ErrorType.API }))
       );
   }
diff --git a/mock-api/mina-sidor-fa/server.js b/mock-api/mina-sidor-fa/server.js
index fb1aa60..de7d9fb 100644
--- a/mock-api/mina-sidor-fa/server.js
+++ b/mock-api/mina-sidor-fa/server.js
@@ -11,18 +11,17 @@ server.use(
     '/api/*': '/$1',
     '*sort=utforandeVerksamhet*': '$1sort=utforandeVerksamhet[0]$2',
     '*sort=tjanst*': '$1sort=tjanst[0]$2',
+    '/users/invite*': '/invites$1',
     '/users/:id': '/employees?ciamUserId=:id',
     '/users*': '/employees$1',
     '/employees*search=*': '/employees$1fullName_like=$2',
     '/employees*onlyEmployeesWithoutAuthorization=*': '/employees$1roles.length_lte=1',
-    '/employees/invite': '/invites',
     '/employees*': '/employees$1',
     '/services*': '/tjanster$1',
     '/participants': '/participants?_embed=employees',
     '/participant/:id': '/participants/:id?_embed=employees',
     '/auth/userinfo': '/currentUser',
     '/auth/organizations': '/currentUser',
-    '/avrop/handledare/assign*': '/avrop$1',
     '/avrop/tjanster*': '/avropTjanster$1',
     '/avrop/handledare*': '/handledare$1',
     '/avrop/utforandeverksamheter*': '/utforandeVerksamheter$1',
@@ -33,7 +32,6 @@ server.use(
     '/deltagare?*': '/avrop?$1',
     '/deltagare/:sokandeId/avrop': '/avrop?sokandeId=:sokandeId',
     '/deltagare/:sokandeId/*': '/deltagare/:sokandeId',
-    '/employees/invite': '/invites',
     '*page=*': '$1_page=$2',
     '*limit=*': '$1_limit=$2',
     '*sort=*': '$1_sort=$2',
@@ -55,8 +53,19 @@ router.render = (req, res) => {
   }
 
   if (method === 'PATCH') {
-    // Returning status 204 as this is the same as in the API, BUT we're not actually updating the mock-api
-    return res.status(204).jsonp();
+    if (pathname === '/handledare/assign') {
+      // Returning status 204 as this is the same as in the API, BUT we're not actually updating the mock-api
+      return res.status(204).jsonp();
+    }
+    if (pathname === '/invites' && req.body?.emails) {
+      return res.status(200).jsonp({
+        data: {
+          invitedUsers: req.body.emails,
+          assignedUsers: [],
+          existingUsersInCurrentOrg: [],
+        },
+      });
+    }
   }
 
   // Return custom error when status is 404.