diff --git a/CHANGELOG.md b/CHANGELOG.md index 926f32a..5cc02c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - **authorization:** Whenever the API throws a "403 Forbidden" error we now show an unauthorized message. [TV-695](https://jira.arbetsformedlingen.se/browse/TV-695) - **avrop:** Now showing spårnamn instead of spårkod inside avrop. [TV-691](https://jira.arbetsformedlingen.se/browse/TV-691) - **avrop:** Fixed error-state on handledare select. [TV-699](https://jira.arbetsformedlingen.se/browse/TV-699) +- **avrop:** Several bugfixes related to avrop. [TV-701](https://jira.arbetsformedlingen.se/browse/TV-701) ## [2.0.0](https://bitbucket.arbetsformedlingen.se/projects/tea/repos/mina-sidor-fa-web/compare/diff?targetBranch=refs%2Ftags%2Fv1.5.0&sourceBranch=refs%2Ftags%2Fv2.0.0) (2021-09-24) diff --git a/apps/mina-sidor-fa/src/app/pages/avrop/avrop.component.ts b/apps/mina-sidor-fa/src/app/pages/avrop/avrop.component.ts index ca239c3..4b79b08 100644 --- a/apps/mina-sidor-fa/src/app/pages/avrop/avrop.component.ts +++ b/apps/mina-sidor-fa/src/app/pages/avrop/avrop.component.ts @@ -1,4 +1,4 @@ -import { ChangeDetectionStrategy, Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component, OnDestroy } from '@angular/core'; import { AvropCompact, AvropCompactData } from '@msfa-models/avrop.model'; import { Handledare } from '@msfa-models/handledare.model'; import { AvropService } from '@msfa-services/avrop.service'; @@ -10,7 +10,7 @@ import { Observable } from 'rxjs'; styleUrls: ['./avrop.component.scss'], changeDetection: ChangeDetectionStrategy.OnPush, }) -export class AvropComponent { +export class AvropComponent implements OnDestroy { readonly totalAmountOfSteps = 3; currentStep$: Observable = this.avropService.currentStep$; error$: Observable = this.avropService.error$; @@ -26,6 +26,10 @@ export class AvropComponent { constructor(private avropService: AvropService) {} + ngOnDestroy(): void { + this.returnToStep1(); + } + updateSelectedAvrop(deltagareList: AvropCompact[], currentStep: number): void { if (currentStep !== 1 && !deltagareList.length) { this.avropService.goToStep1(); diff --git a/apps/mina-sidor-fa/src/app/pages/avrop/components/avrop-list/avrop-list.component.html b/apps/mina-sidor-fa/src/app/pages/avrop/components/avrop-list/avrop-list.component.html index 0583a66..9d4989a 100644 --- a/apps/mina-sidor-fa/src/app/pages/avrop/components/avrop-list/avrop-list.component.html +++ b/apps/mina-sidor-fa/src/app/pages/avrop/components/avrop-list/avrop-list.component.html @@ -1,13 +1,5 @@
-
- -
  • selectedAvrop.id === avrop.id); } - toggleAllAvrop(selected: boolean): void { - if (selected && this.selectedAvrop?.length !== this.availableAvrop?.length) { - this.selectionChanged.emit(this.availableAvrop); - } else if (!selected && this.selectedAvrop.length) { - this.selectionChanged.emit([]); - } - } - toggleSelectedAvrop(avrop: Avrop, selected: boolean): void { const avropIsSelected = !!this.selectedAvrop?.find(selectedAvrop => selectedAvrop.id === avrop.id); diff --git a/apps/mina-sidor-fa/src/app/shared/models/avrop.model.ts b/apps/mina-sidor-fa/src/app/shared/models/avrop.model.ts index 98327cb..cb04f72 100644 --- a/apps/mina-sidor-fa/src/app/shared/models/avrop.model.ts +++ b/apps/mina-sidor-fa/src/app/shared/models/avrop.model.ts @@ -13,7 +13,7 @@ export interface AvropCompact { sprakstod: string; // sprakstod utforandeAdress: string; // adress trackCode: string; // sparkod - trackName: string; // sparNamn + trackName: TrackName; // sparNamn } export interface Avrop extends AvropCompact { @@ -60,11 +60,11 @@ export function mapAvropResponseToAvrop(data: AvropResponse): Avrop { sprakstod: sprakstod, utforandeAdress: adress, trackCode: sparkod, - trackName: TrackName[sparkod] || TrackName.UNKNOWN, + trackName: (TrackName[sparkod] || TrackName.UNKNOWN) as TrackName, genomforandeReferens, participationFrequency: deltagandeGrad, utforandeVerksamhet: utforandeverksamhet, - handledareCiamUserId, + handledareCiamUserId: handledareCiamUserId, handledare, }; } diff --git a/apps/mina-sidor-fa/src/assets/CHANGELOG.md b/apps/mina-sidor-fa/src/assets/CHANGELOG.md index 926f32a..5cc02c4 100644 --- a/apps/mina-sidor-fa/src/assets/CHANGELOG.md +++ b/apps/mina-sidor-fa/src/assets/CHANGELOG.md @@ -6,6 +6,7 @@ - **authorization:** Whenever the API throws a "403 Forbidden" error we now show an unauthorized message. [TV-695](https://jira.arbetsformedlingen.se/browse/TV-695) - **avrop:** Now showing spårnamn instead of spårkod inside avrop. [TV-691](https://jira.arbetsformedlingen.se/browse/TV-691) - **avrop:** Fixed error-state on handledare select. [TV-699](https://jira.arbetsformedlingen.se/browse/TV-699) +- **avrop:** Several bugfixes related to avrop. [TV-701](https://jira.arbetsformedlingen.se/browse/TV-701) ## [2.0.0](https://bitbucket.arbetsformedlingen.se/projects/tea/repos/mina-sidor-fa-web/compare/diff?targetBranch=refs%2Ftags%2Fv1.5.0&sourceBranch=refs%2Ftags%2Fv2.0.0) (2021-09-24)